open source recovery menu

[devshelper]

menu peolpe have complained about some bugs of the recovery menus on 6.20 tn-d permanent.
these bugs appear because these menus are not designed for 6.20.
so lets all create a menu that will be compatible with tn hen -d perm.
here is the source code of the menu:

Code: Select all

#include <pspkernel.h>
#include <pspcallbacks.h>
#include <pspctrl.h>
#include <graphics.h>
#include <pspdebug.h>

#define RGB(r, g, b) ((r)|((g)<<8)|((b)<<16))

#define printf pspDebugScreenPrintf

PSP_MODULE_INFO("Menu Example",0,1,1);

//colors used later
Color green = RGB(0,255,0), red = RGB(255,0,0), black = RGB(0,0,0), blue = RGB (0,0,255);

char menuItems[10][25] = {
   {"USB"},
   {"RECOVERY"},
   {"F0 BACKUP"},
   {"F1 BACKUP"},
   {"CPU GAME"},
   {"CPU XMB"},
   {"PLUGINS"},
   {"FAKE REGION"},
   {"RESET DEVICE"},
   {"RESET VSH"},
};

int timer,select,foo;
SceCtrlData pad;

int main() {
    pspDebugScreenInit();
    pspDebugScreenClear();
   initGraphics();
   SetupCallbacks();
   while(1) {
      sceCtrlReadBufferPositive(&pad,1);
      fillScreenRect(black,0,0,480,272);
      timer++;
      for(foo=0;foo<10;foo++) {
         printTextScreen(200,foo*10+70,menuItems[foo],red);
      }
      
      printTextScreen(200,select*10+70,menuItems[select],green);   

   if((pad.Buttons & PSP_CTRL_UP) && (timer > 10) && (select > 0)) {
         select--;
         timer = 0;
      } else if ((pad.Buttons & PSP_CTRL_DOWN) && (timer > 10) && (select < 9)) {
         select++;
         timer = 0;
      }   

      
      flipScreen();
   }
   return 0;
}      

i will edit the code so that this menu becomes perfect.
i would also like you to make suggestions on how to improve it!!!
thnx

[m0skit0]

There's no such thing as perfect software.

[devshelper]

no.
but looking for perfection improves everything.
i know that this library:

Code: Select all

sceKernelExitVSHVSH(NULL);

restarts the vsh.
but when i put this code:

Code: Select all

      if((pad.Buttons & PSP_CTRL_CROSS) && (select == 9)) {
      sceKernelExitVSHVSH(NULL);
      }

the homebrew crashes without even reaching the menu.
whats wrong?

[m0skit0]

That line is correct. Put the whole code, the problem is elsewhere.

[devshelper]

Code: Select all

#include <pspkernel.h>
#include <pspcallbacks.h>
#include <pspctrl.h>
#include <graphics.h>
#include <pspdebug.h>
#include <psploadexec_kernel.h>

#define RGB(r, g, b) ((r)|((g)<<8)|((b)<<16))

#define printf pspDebugScreenPrintf

PSP_MODULE_INFO("Menu Example",0,1,1);

//colors used later
Color green = RGB(0,255,0), red = RGB(255,0,0), black = RGB(0,0,0), blue = RGB (0,0,255);

char menuItems[10][25] = {
   {"USB"},
   {"RECOVERY"},
   {"F0 BACKUP"},
   {"F1 BACKUP"},
   {"CPU GAME"},
   {"CPU XMB"},
   {"PLUGINS"},
   {"FAKE REGION"},
   {"RESET DEVICE"},
   {"RESET VSH"},
};

int timer,select,foo;
SceCtrlData pad;

int main() {
    pspDebugScreenInit();
    pspDebugScreenClear();
   initGraphics();
   SetupCallbacks();
   while(1) {
      sceCtrlReadBufferPositive(&pad,1);
      fillScreenRect(black,0,0,480,272);
      timer++;
      for(foo=0;foo<10;foo++) {
         printTextScreen(200,foo*10+70,menuItems[foo],red);
      }
      
      printTextScreen(200,select*10+70,menuItems[select],green);   

   if((pad.Buttons & PSP_CTRL_UP) && (timer > 10) && (select > 0)) {
         select--;
         timer = 0;
      } else if ((pad.Buttons & PSP_CTRL_DOWN) && (timer > 10) && (select < 9)) {
         select++;
         timer = 0;
      }   
      
        flipScreen();
      
      if((pad.Buttons & PSP_CTRL_CROSS) && (select == 9)) {
      sceKernelExitVSHVSH(NULL);
      }
      
   }
   return 0;
}      




      

[m0skit0]

You cannot put a while(1) without a delay, Syscon will detect that as a hang/crash and power off the PSP. You need to leave other code (specially kernel code) execute, using sceKernelDelayThread inside your loop.

FYI PSP has no real multitasking, it's preemptive multitasking (tasks should release CPU themselves, kernel does not enforce that).

[JJS]

The while(1) loop is ok in this case because sceCtrlReadBufferPositive waits for vsync. So it doesn't run more than 60 times a second.

But I am wondering if this thread is not a rehash of the last one with the same code in it.

[devshelper]

can you practically show me what should i do?

[waratte]

Try moving a return statement down your main loop as way to find the problem. Compile, run on psp, then wait a few seconds. Push the home button to check if the grey screen appears, the one that asks you if you want to exit the game. If it does, move the return statement down one line until, the grey screen doesn't appear anymore. The line above your return statement could be the problem. This is a way I check for crashing errors in my programme, there may be better methods but I like this one. Also as a suggestion, you could have your "foo" variable in your for loop instead of outside your main unless you plan on using it throughout the code.

[m0skit0]

Of course there are better methods. They are called "debugging", which is almost as important as programming.